From 39abc4e97317b64597147200ed313216c86e24d5 Mon Sep 17 00:00:00 2001
From: Kristoffer Dalby <kradalby@kradalby.no>
Date: Sat, 2 Oct 2021 15:38:53 +0100
Subject: [PATCH] Clarify error messages for nodes that are not connected

If a node does not have an update channel, it is probably not connected,
clarify the log messages and make sure we dont print that it was updated
successfully (continue, not return)
---
 machine.go | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/machine.go b/machine.go
index 2d4bb518..1cd2d95f 100644
--- a/machine.go
+++ b/machine.go
@@ -308,8 +308,8 @@ func (h *Headscale) notifyChangesToPeers(m *Machine) {
 				Str("func", "notifyChangesToPeers").
 				Str("machine", m.Name).
 				Str("peer", p.Name).
-				Msgf("Peer %s does not appear to be polling", p.Name)
-			return
+				Msgf("Peer %s does not have an open update client, skipping.", p.Name)
+			continue
 		}
 		log.Trace().
 			Str("func", "notifyChangesToPeers").
@@ -380,11 +380,12 @@ func (h *Headscale) sendRequestOnUpdateChannel(m *tailcfg.Node) error {
 				Msgf("Notified machine %s", m.Name)
 		}
 	} else {
+		err := errors.New("machine does not have an open update channel")
 		log.Info().
 			Str("func", "requestUpdate").
 			Str("machine", m.Name).
-			Msgf("Machine %s does not appear to be polling", m.Name)
-		return errors.New("machine does not seem to be polling")
+			Msgf("Machine %s does not have an open update channel", m.Name)
+		return err
 	}
 	return nil
 }