From 4f294c243c159a27073816ad9453b0b2cb832d6b Mon Sep 17 00:00:00 2001
From: ArcticLampyrid <ArcticLampyrid@outlook.com>
Date: Fri, 15 Nov 2024 02:33:48 +0800
Subject: [PATCH] tests(dsic): use string builder for cmd args

---
 integration/dsic/dsic.go | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/integration/dsic/dsic.go b/integration/dsic/dsic.go
index 4ea659c9..4c948c48 100644
--- a/integration/dsic/dsic.go
+++ b/integration/dsic/dsic.go
@@ -135,14 +135,15 @@ func New(
 		opt(dsic)
 	}
 
-	cmdArgs := "--hostname=" + hostname
-	cmdArgs += " --certmode=manual"
-	cmdArgs += " --certdir=" + DERPerCertRoot
-	cmdArgs += " --a=:" + strconv.Itoa(dsic.derpPort)
-	cmdArgs += " --stun=true"
-	cmdArgs += " --stun-port=" + strconv.Itoa(dsic.stunPort)
+	var cmdArgs strings.Builder
+	fmt.Fprintf(&cmdArgs, "--hostname=%s", hostname)
+	fmt.Fprintf(&cmdArgs, " --certmode=manual")
+	fmt.Fprintf(&cmdArgs, " --certdir=%s", DERPerCertRoot)
+	fmt.Fprintf(&cmdArgs, " --a=:%d", dsic.derpPort)
+	fmt.Fprintf(&cmdArgs, " --stun=true")
+	fmt.Fprintf(&cmdArgs, " --stun-port=%d", dsic.stunPort)
 	if dsic.withVerifyClientURL != "" {
-		cmdArgs += " --verify-client-url=" + dsic.withVerifyClientURL
+		fmt.Fprintf(&cmdArgs, " --verify-client-url=%s", dsic.withVerifyClientURL)
 	}
 
 	runOptions := &dockertest.RunOptions{
@@ -150,7 +151,7 @@ func New(
 		Networks:   []*dockertest.Network{dsic.network},
 		ExtraHosts: dsic.withExtraHosts,
 		// we currently need to give us some time to inject the certificate further down.
-		Entrypoint: []string{"/bin/sh", "-c", "/bin/sleep 3 ; update-ca-certificates ; derper " + cmdArgs},
+		Entrypoint: []string{"/bin/sh", "-c", "/bin/sleep 3 ; update-ca-certificates ; derper " + cmdArgs.String()},
 		ExposedPorts: []string{
 			"80/tcp",
 			fmt.Sprintf("%d/tcp", dsic.derpPort),