From 6ed79b7bb8217547af814ec6761d0c45f72e35f9 Mon Sep 17 00:00:00 2001
From: Deon Thomas <deon.thomas.gy@gmail.com>
Date: Sun, 8 May 2022 15:21:10 -0400
Subject: [PATCH] order Ip Address, IPv4 first, cleanup

---
 cmd/headscale/cli/nodes.go | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/cmd/headscale/cli/nodes.go b/cmd/headscale/cli/nodes.go
index 805d2ee0..9159b32b 100644
--- a/cmd/headscale/cli/nodes.go
+++ b/cmd/headscale/cli/nodes.go
@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"log"
 	"strconv"
+	"strings"
 	"time"
 
 	survey "github.com/AlecAivazis/survey/v2"
@@ -453,13 +454,14 @@ func nodesToPtables(
 			namespace = pterm.LightYellow(machine.Namespace.Name)
 		}
 
-		var IpAddresses string
-		if netaddr.MustParseIP(machine.IpAddresses[0]).Is4() {
-			IpAddresses = machine.IpAddresses[0]
-			IpAddresses += ", " + machine.IpAddresses[1]
-		} else {
-			IpAddresses = machine.IpAddresses[1]
-			IpAddresses += ", " + machine.IpAddresses[0]
+		var IpV4Address string
+		var IpV6Address string
+		for _, addr := range machine.IpAddresses {
+			if netaddr.MustParseIP(addr).Is4() {
+				IpV4Address = addr
+			} else {
+				IpV6Address = addr
+			}
 		}
 
 		tableData = append(
@@ -469,7 +471,7 @@ func nodesToPtables(
 				machine.Name,
 				nodeKey.ShortString(),
 				namespace,
-				IpAddresses,
+				strings.Join([]string{IpV4Address, IpV6Address}, ", "),
 				strconv.FormatBool(ephemeral),
 				lastSeenTime,
 				online,