devproje/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2024-11-29 18:33:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

feat: add length error if hostname too long

Browse source
This commit is contained in:
Adrien Raffin-Caboisse 2022-02-23 14:21:46 +01:00
parent 4f1f235a2e
commit 972bef1194
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
machine.go
View file

@ -25,6 +25,11 @@ const (
errMachineAlreadyRegistered = Error("machine already registered") errMachineAlreadyRegistered = Error("machine already registered")
errMachineRouteIsNotAvailable = Error("route is not available on machine") errMachineRouteIsNotAvailable = Error("route is not available on machine")
errMachineAddressesInvalid = Error("failed to parse machine addresses") errMachineAddressesInvalid = Error("failed to parse machine addresses")
errHostnameTooLong = Error("Hostname too long")
)
const (
maxHostnameLength = 255
) )
// Machine is a Headscale client. // Machine is a Headscale client.
@ -727,6 +732,13 @@ func (machine Machine) toNode(
machine.Namespace.Name, machine.Namespace.Name,
baseDomain, baseDomain,
) )
if len(hostname) > maxHostnameLength {
return nil, fmt.Errorf(
"hostname %q is too long it cannot except 255 ASCII chars: %w",
hostname,
errHostnameTooLong,
)
}
} else { } else {
hostname = machine.Name hostname = machine.Name
} }