Split lint and test CI files

This commit splits the lint and test steps into two different jobs in
github actions.

Consider this a suggestion, the idea is that when we look at PRs we will
see explicitly which one of the two types of checks fails without having
to open Github actions.
This commit is contained in:
Kristoffer Dalby 2021-08-21 15:40:27 +01:00
parent 47b61c0cea
commit f749be1490
No known key found for this signature in database
GPG key ID: 09F62DC067465735
2 changed files with 56 additions and 29 deletions

39
.github/workflows/lint.yml vendored Normal file
View file

@ -0,0 +1,39 @@
name: CI
on: [push, pull_request]
jobs:
# The "build" workflow
test:
# The type of runner that the job will run on
runs-on: ubuntu-latest
# Steps represent a sequence of tasks that will be executed as part of the job
steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v2
# Install and run golangci-lint as a separate step, it's much faster this
# way because this action has caching. It'll get run again in `make lint`
# below, but it's still much faster in the end than installing
# golangci-lint manually in the `Run lint` step.
- uses: golangci/golangci-lint-action@v2
with:
args: --timeout 2m
# Setup Go
- name: Setup Go
uses: actions/setup-go@v2
with:
go-version: "1.16.3" # The Go version to download (if necessary) and use.
# Install all the dependencies
- name: Install dependencies
run: |
go version
go install golang.org/x/lint/golint@latest
sudo apt update
sudo apt install -y make
- name: Run lint
run: make lint

View file

@ -10,36 +10,24 @@ jobs:
# Steps represent a sequence of tasks that will be executed as part of the job # Steps represent a sequence of tasks that will be executed as part of the job
steps: steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v2 - uses: actions/checkout@v2
# Install and run golangci-lint as a separate step, it's much faster this # Setup Go
# way because this action has caching. It'll get run again in `make lint` - name: Setup Go
# below, but it's still much faster in the end than installing uses: actions/setup-go@v2
# golangci-lint manually in the `Run lint` step. with:
- uses: golangci/golangci-lint-action@v2 go-version: "1.16.3" # The Go version to download (if necessary) and use.
with:
args: --timeout 2m
# Setup Go # Install all the dependencies
- name: Setup Go - name: Install dependencies
uses: actions/setup-go@v2 run: |
with: go version
go-version: '1.16.3' # The Go version to download (if necessary) and use. sudo apt update
sudo apt install -y make
# Install all the dependencies - name: Run tests
- name: Install dependencies run: make test
run: |
go version
go install golang.org/x/lint/golint@latest
sudo apt update
sudo apt install -y make
- name: Run tests - name: Run build
run: make test run: make
- name: Run lint
run: make lint
- name: Run build
run: make