Merge branch 'Vencord:main' into zoom-parity

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -14,11 +14,12 @@ body:
               Make sure both Vesktop and Vencord are fully up to date. You can update Vencord by right-clicking the Vesktop tray icon and pressing "Update Vencord"
 
               **DO NOT REPORT** any of the following issues:
-              - Purely graphical glitches like flickering, scaling issues, etc: Issue with your gpu. Nothing we can do, update drivers or disable hardware acceleration
+              - GPU related issues. These are **you** issues and you have to fix them. You can disable hardware acceleration or run with --disable-gpu. 
+                - Purely graphical glitches like flickering, scaling issues
+                - App crashing with mentions of the gpu process in the stacktrace
+                - Screenshare not starting, black screening or crashing
               - Vencord related issues: This is the Vesktop repo, not Vencord
-              - **SCREENSHARE NOT STARTING** / black screening on Linux: Issue with your desktop environment, specifically its xdg-desktop-portal.
-                If you're on flatpak, try using native version. If that also doesn't work, you have to fix your systen. Inspect errors and google around.
-
+              
               Linux users: Please only report issues with supported packages (flatpak and any builds from the README / releases).
               We do not support other packages, like the AUR or Nix packages, so please first make sure your issue is reproducible with official releases,
               like [our Flatpak](https://flathub.org/apps/dev.vencord.Vesktop) or [AppImage](https://vencord.dev/download/vesktop/amd64/appimage)
@@ -50,6 +51,15 @@ body:
       validations:
           required: false
 
+    - type: input
+      id: install-type
+      attributes:
+          label: Package Type
+          description: What kind of Vesktop package are you using? (Setup exe, Portable, Flatpak, AppImage, Deb, etc)
+          placeholder: Flatpak
+      validations:
+          required: true
+
     - type: textarea
       id: bug-description
       attributes:
@@ -85,7 +95,7 @@ body:
       id: debug-logs
       attributes:
           label: Debug Logs
-          description: Run vesktop from the command line. Include the relevant command line output here
+          description: Run vesktop from the command line. Include the relevant command line output here. If there are any lines that seem relevant, try googling them or searching existing issues
           value: |
               ```
               Replace this text with your crash-log. Do not remove the backticks

src/main/venmic.ts

@@ -72,7 +72,7 @@ ipcMain.handle(IpcEvents.VIRT_MIC_LIST, () => {
     const { granularSelect } = Settings.store.audio ?? {};
 
     const targets = obtainVenmic()
-        ?.list(granularSelect ? ["application.process.id"] : undefined)
+        ?.list(granularSelect ? ["node.name"] : undefined)
         .filter(s => s["application.process.id"] !== audioPid);
 
     return targets ? { ok: true, targets, hasPipewirePulse } : { ok: false, isGlibCxxOutdated };

src/renderer/components/ScreenSharePicker.tsx

@@ -254,7 +254,13 @@ function AudioSettingsModal({
                 </Switch>
                 <Switch
                     hideBorder
-                    onChange={v => (Settings.audio = { ...Settings.audio, ignoreDevices: v })}
+                    onChange={v =>
+                        (Settings.audio = {
+                            ...Settings.audio,
+                            ignoreDevices: v,
+                            deviceSelect: v ? false : Settings.audio?.deviceSelect
+                        })
+                    }
                     value={Settings.audio?.ignoreDevices ?? true}
                     note={<>Exclude device nodes, such as nodes belonging to microphones or speakers.</>}
                 >
@@ -271,6 +277,23 @@ function AudioSettingsModal({
                 >
                     Granular Selection
                 </Switch>
+                <Switch
+                    hideBorder
+                    onChange={value => {
+                        Settings.audio = { ...Settings.audio, deviceSelect: value };
+                        setAudioSources("None");
+                    }}
+                    value={Settings.audio?.deviceSelect ?? false}
+                    disabled={Settings.audio?.ignoreDevices}
+                    note={
+                        <>
+                            Allow to select devices such as microphones. Requires <b>Ignore Devices</b> to be turned
+                            off.
+                        </>
+                    }
+                >
+                    Device Selection
+                </Switch>
             </Modals.ModalContent>
             <Modals.ModalFooter className="vcd-screen-picker-footer">
                 <Button color={Button.Colors.TRANSPARENT} onClick={close}>
@@ -423,6 +446,7 @@ function StreamSettings({
                         openSettings={openSettings}
                         includeSources={settings.includeSources}
                         excludeSources={settings.excludeSources}
+                        deviceSelect={Settings.audio?.deviceSelect}
                         granularSelect={Settings.audio?.granularSelect}
                         setIncludeSources={sources => setSettings(s => ({ ...s, includeSources: sources }))}
                         setExcludeSources={sources => setSettings(s => ({ ...s, excludeSources: sources }))}
@@ -441,13 +465,23 @@ function hasMatchingProps(value: Node, other: Node) {
     return Object.keys(value).every(key => value[key] === other[key]);
 }
 
-function mapToAudioItem(node: AudioSource, granularSelect?: boolean): AudioItem[] {
+function mapToAudioItem(node: AudioSource, granularSelect?: boolean, deviceSelect?: boolean): AudioItem[] {
     if (isSpecialSource(node)) {
         return [{ name: node, value: node }];
     }
 
     const rtn: AudioItem[] = [];
 
+    const mediaClass = node["media.class"];
+
+    if (mediaClass?.includes("Video") || mediaClass?.includes("Midi")) {
+        return rtn;
+    }
+
+    if (!deviceSelect && node["device.id"]) {
+        return rtn;
+    }
+
     const name = node["application.name"];
 
     if (name) {
@@ -458,9 +492,15 @@ function mapToAudioItem(node: AudioSource, granularSelect?: boolean): AudioItem[
         return rtn;
     }
 
-    const binary = node["application.process.binary"];
+    const rawName = node["node.name"];
 
     if (!name) {
+        rtn.push({ name: rawName, value: { "node.name": rawName } });
+    }
+
+    const binary = node["application.process.binary"];
+
+    if (!name && binary) {
         rtn.push({ name: binary, value: { "application.process.binary": binary } });
     }
 
@@ -469,10 +509,12 @@ function mapToAudioItem(node: AudioSource, granularSelect?: boolean): AudioItem[
     const first = rtn[0];
     const firstValues = first.value as Node;
 
-    rtn.push({
-        name: `${first.name} (${pid})`,
-        value: { ...firstValues, "application.process.id": pid }
-    });
+    if (pid) {
+        rtn.push({
+            name: `${first.name} (${pid})`,
+            value: { ...firstValues, "application.process.id": pid }
+        });
+    }
 
     const mediaName = node["media.name"];
 
@@ -483,17 +525,13 @@ function mapToAudioItem(node: AudioSource, granularSelect?: boolean): AudioItem[
         });
     }
 
-    const mediaClass = node["media.class"];
-
-    if (!mediaClass) {
-        return rtn;
+    if (mediaClass) {
+        rtn.push({
+            name: `${first.name} [${mediaClass}]`,
+            value: { ...firstValues, "media.class": mediaClass }
+        });
     }
 
-    rtn.push({
-        name: `${first.name} [${mediaClass}]`,
-        value: { ...firstValues, "media.class": mediaClass }
-    });
-
     return rtn;
 }
 
@@ -535,6 +573,7 @@ function updateItems(setSources: (s: AudioSources) => void, sources?: AudioSourc
 function AudioSourcePickerLinux({
     includeSources,
     excludeSources,
+    deviceSelect,
     granularSelect,
     openSettings,
     setIncludeSources,
@@ -542,6 +581,7 @@ function AudioSourcePickerLinux({
 }: {
     includeSources?: AudioSources;
     excludeSources?: AudioSources;
+    deviceSelect?: boolean;
     granularSelect?: boolean;
     openSettings: () => void;
     setIncludeSources: (s: AudioSources) => void;
@@ -592,7 +632,7 @@ function AudioSourcePickerLinux({
 
     const allSources = sources.ok
         ? [...specialSources, ...sources.targets]
-              .map(target => mapToAudioItem(target, granularSelect))
+              .map(target => mapToAudioItem(target, granularSelect, deviceSelect))
               .flat()
               .filter(uniqueName)
         : [];

src/shared/settings.d.ts

@@ -31,6 +31,8 @@ export interface Settings {
 
     audio?: {
         workaround?: boolean;
+
+        deviceSelect?: boolean;
         granularSelect?: boolean;
 
         ignoreVirtual?: boolean;