From 61bbd7f6aaeaecab20b9ae450aeed80711805c84 Mon Sep 17 00:00:00 2001 From: vee Date: Thu, 11 Jul 2024 05:31:07 +0200 Subject: [PATCH 1/5] Update bug_report.yml --- .github/ISSUE_TEMPLATE/bug_report.yml | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 6692098..f5cf0b4 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -14,11 +14,12 @@ body: Make sure both Vesktop and Vencord are fully up to date. You can update Vencord by right-clicking the Vesktop tray icon and pressing "Update Vencord" **DO NOT REPORT** any of the following issues: - - Purely graphical glitches like flickering, scaling issues, etc: Issue with your gpu. Nothing we can do, update drivers or disable hardware acceleration + - GPU related issues. These are **you** issues and you have to fix them. You can disable hardware acceleration or run with --disable-gpu. + - Purely graphical glitches like flickering, scaling issues + - App crashing with mentions of the gpu process in the stacktrace + - Screenshare not starting, black screening or crashing - Vencord related issues: This is the Vesktop repo, not Vencord - - **SCREENSHARE NOT STARTING** / black screening on Linux: Issue with your desktop environment, specifically its xdg-desktop-portal. - If you're on flatpak, try using native version. If that also doesn't work, you have to fix your systen. Inspect errors and google around. - + Linux users: Please only report issues with supported packages (flatpak and any builds from the README / releases). We do not support other packages, like the AUR or Nix packages, so please first make sure your issue is reproducible with official releases, like [our Flatpak](https://flathub.org/apps/dev.vencord.Vesktop) or [AppImage](https://vencord.dev/download/vesktop/amd64/appimage) @@ -50,6 +51,15 @@ body: validations: required: false + - type: input + id: install-type + attributes: + label: Package Type + description: What kind of Vesktop package are you using? (Setup exe, Portable, Flatpak, AppImage, Deb, etc) + placeholder: Flatpak + validations: + required: true + - type: textarea id: bug-description attributes: @@ -85,7 +95,7 @@ body: id: debug-logs attributes: label: Debug Logs - description: Run vesktop from the command line. Include the relevant command line output here + description: Run vesktop from the command line. Include the relevant command line output here. If there are any lines that seem relevant, try googling them or searching existing issues value: | ``` Replace this text with your crash-log. Do not remove the backticks From 9acc6652ff72531194f5159576abcf79845edc84 Mon Sep 17 00:00:00 2001 From: Noah <37805707+Curve@users.noreply.github.com> Date: Fri, 12 Jul 2024 16:14:18 +0200 Subject: [PATCH 2/5] AudioShare: Even more granular selection, Allow device sharing (#750) --- src/main/venmic.ts | 2 +- src/renderer/components/ScreenSharePicker.tsx | 74 ++++++++++++++----- src/shared/settings.d.ts | 2 + 3 files changed, 60 insertions(+), 18 deletions(-) diff --git a/src/main/venmic.ts b/src/main/venmic.ts index 885fd2d..c127e90 100644 --- a/src/main/venmic.ts +++ b/src/main/venmic.ts @@ -72,7 +72,7 @@ ipcMain.handle(IpcEvents.VIRT_MIC_LIST, () => { const { granularSelect } = Settings.store.audio ?? {}; const targets = obtainVenmic() - ?.list(granularSelect ? ["application.process.id"] : undefined) + ?.list(granularSelect ? ["node.name"] : undefined) .filter(s => s["application.process.id"] !== audioPid); return targets ? { ok: true, targets, hasPipewirePulse } : { ok: false, isGlibCxxOutdated }; diff --git a/src/renderer/components/ScreenSharePicker.tsx b/src/renderer/components/ScreenSharePicker.tsx index c7403b9..2055067 100644 --- a/src/renderer/components/ScreenSharePicker.tsx +++ b/src/renderer/components/ScreenSharePicker.tsx @@ -254,7 +254,13 @@ function AudioSettingsModal({ (Settings.audio = { ...Settings.audio, ignoreDevices: v })} + onChange={v => + (Settings.audio = { + ...Settings.audio, + ignoreDevices: v, + deviceSelect: v ? false : Settings.audio?.deviceSelect + }) + } value={Settings.audio?.ignoreDevices ?? true} note={<>Exclude device nodes, such as nodes belonging to microphones or speakers.} > @@ -271,6 +277,23 @@ function AudioSettingsModal({ > Granular Selection + { + Settings.audio = { ...Settings.audio, deviceSelect: value }; + setAudioSources("None"); + }} + value={Settings.audio?.deviceSelect ?? false} + disabled={Settings.audio?.ignoreDevices} + note={ + <> + Allow to select devices such as microphones. Requires Ignore Devices to be turned + off. + + } + > + Device Selection +