Merge pull request #131 from iopred/docs

Allow Ready events to fire even after a unmarshalling error.
This commit is contained in:
Bruce 2016-02-22 10:39:59 -06:00
commit ec5dd888c1
2 changed files with 12 additions and 19 deletions

View file

@ -220,19 +220,9 @@ type User struct {
Username string `json:"username"`
Avatar string `json:"Avatar"`
Verified bool `json:"verified"`
//Discriminator int `json:"discriminator,string"` // TODO: See below
Discriminator string `json:"discriminator"`
}
// TODO: Research issue.
// Discriminator sometimes comes as a string
// and sometimes it comes as a int. Weird.
// to avoid errors I've just commented it out
// but it doesn't seem to just kill the whole
// program. Heartbeat is taken on READY even
// with error and the system continues to read
// it just doesn't seem able to handle this one
// field correctly. Need to research this more.
// A Settings stores data for a specific users Discord client settings.
type Settings struct {
RenderEmbeds bool `json:"render_embeds"`
@ -274,7 +264,7 @@ type RateLimit struct {
// A ReadState stores data on the read state of channels.
type ReadState struct {
MentionCount int
MentionCount int `json:"mention_count"`
LastMessageID string `json:"last_message_id"`
ID string `json:"id"`
}

View file

@ -284,9 +284,12 @@ func (s *Session) event(messageType int, message []byte) {
// Attempt to unmarshal our event.
// If there is an error we should handle the event itself.
if err = unmarshal(e.RawData, i); err != nil {
fmt.Println("Unable to unmarshal event data.")
fmt.Println("Unable to unmarshal event data.", err)
// Ready events must fire, even if they are empty.
if e.Type != "READY" {
i = e
}
}
} else {
fmt.Println("Unknown event.")
i = e