pothtonswer/discordmuffin
1
0
Fork 1
Code Issues 2 Pull requests 1 Projects 2 Releases Packages Wiki Activity Actions

Do not call session onEvent as goroutine

Browse source 
This is a stability improvement but may have a slight performance
impact. This change will be reviewed again later.  Doing this solves a
data race issue with the Sequence number that must be tracked for
gateway resume and heartbeats.  Event specific handlers are now called
as a goroutine though.
This commit is contained in:
Bruce Marriner 2016-06-17 12:24:32 -05:00
parent 34c4ad5aa2
commit face6df4b6
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
wsapi.go
View file

@ -161,7 +161,7 @@ func (s *Session) listen(wsConn *websocket.Conn, listening <-chan interface{}) {
return return
default: default:
go s.onEvent(messageType, message) s.onEvent(messageType, message)
} }
} }
@ -377,7 +377,7 @@ func (s *Session) onEvent(messageType int, message []byte) {
// it's better to pass along what we received than nothing at all. // it's better to pass along what we received than nothing at all.
// TODO: Think about that decision :) // TODO: Think about that decision :)
// Either way, READY events must fire, even with errors. // Either way, READY events must fire, even with errors.
s.handle(i) go s.handle(i)
} else { } else {
s.log(LogWarning, "unknown event: Op: %d, Seq: %d, Type: %s, Data: %s", e.Operation, e.Sequence, e.Type, string(e.RawData)) s.log(LogWarning, "unknown event: Op: %d, Seq: %d, Type: %s, Data: %s", e.Operation, e.Sequence, e.Type, string(e.RawData))
@ -385,7 +385,7 @@ func (s *Session) onEvent(messageType int, message []byte) {
// Emit event to the OnEvent handler // Emit event to the OnEvent handler
e.Struct = i e.Struct = i
s.handle(e) go s.handle(e)
} }
// ------------------------------------------------------------------------------------------------ // ------------------------------------------------------------------------------------------------